fix: Use logical OR instead of bitwise OR#5763
Merged
maddeleine merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
boquan-fang
approved these changes
Feb 26, 2026
CarolYeh910
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Fixing bugs from a recent PR.
Why
Well they're bugs so...
How
Use logical OR instead of bitwise OR. Also apparently I initialized s2n_pkey_type wrong, as that is actually a enum and not a struct.
Callouts
related to #5736
Testing
Related
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.