refactor(integration): utilities module with cert materials#5753
Merged
refactor(integration): utilities module with cert materials#5753
Conversation
jouho
reviewed
Feb 20, 2026
Contributor
jouho
left a comment
There was a problem hiding this comment.
Seems like there are a couple clippy failures. Otherwise lgtm.
kaukabrizvi
approved these changes
Feb 20, 2026
Co-authored-by: kaukabrizvi <100529019+kaukabrizvi@users.noreply.github.com>
jouho
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Move the CertMaterials definition to an external module.
Why
I am adding integration tests for the errors returned during various mTLS scenarios, and need to access lots of differents certs to make that happen.
How
Just moving stuff around.
Related
To my effort to add integration tests cases for mTLS failure cases.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.