Conversation
dougch
left a comment
There was a problem hiding this comment.
Reasonable- thanks for splitting this out.
maddeleine
left a comment
There was a problem hiding this comment.
If you're adding a new workflow, I believe that you have to add it to required checks for it to actually block a PR? Maybe @dougch knows?
|
This change gets stuck at merge queue because it expects reports back from the workflow, but currently isn't being triggered upon
There isn't a good way to test this change other than queuing this change to see its effect |
Goal
Make the PR title check trigger upon editing PR title
Why
The PR title check doesn't re-run when the title is edited, since
editedisn't a defaultpull_requestactivity type. Re-running the workflow doesn't help either as it replays the original event payload with the old title.How
Split the
validate-pr-titlejob out ofci_linting.ymlinto a new dedicated workflow (ci_pr_title.yml). The new workflow triggers onpull_requestwith activity types[opened, synchronize, reopened, edited]. Theeditedtype ensures the check re-runs whenever the PR title (or body/base branch) is modified, so the validation always references the latest title.This is split into a separate workflow to avoid re-triggering all the other linting jobs (cppcheck, clang-format, etc.) on title edits.
Callouts
Testing
Confirmed by changing the title of this PR
Related
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.