Conversation
dougch
approved these changes
Feb 17, 2026
jmayclin
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Fix the PR title conventional commit validation so it actually runs on pull requests.
Why
The
validate-pr-titlejob'sifcondition checks forpull_request_target, but the workflow is triggered bypull_request. Since these are different event types, the validation step is always skipped.How
Change
github.event_name == 'pull_request_target'togithub.event_name == 'pull_request'in theifconditions of thevalidate-pr-titlejob to match the workflow's trigger event.Testing
The workflow is now running.
Check failed when I set incorrect/unconventional PR title: https://github.com/aws/s2n-tls/actions/runs/22115920366/job/63923887211?pr=5744
Check succeed when I follow conventional PR title: https://github.com/aws/s2n-tls/actions/runs/22116045551/job/63924316532?pr=5744
Related
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.