Skip to content

ci: temporary replace clang-format-action#5735

Merged
jouho merged 3 commits intoaws:mainfrom
jouho:fix-clang-format
Feb 16, 2026
Merged

ci: temporary replace clang-format-action#5735
jouho merged 3 commits intoaws:mainfrom
jouho:fix-clang-format

Conversation

@jouho
Copy link
Copy Markdown
Contributor

@jouho jouho commented Feb 16, 2026

Goal

Unblock the CI

Why

Currently there are two issues:

  1. clang-format-action started failing in the CI. Example failure: https://github.com/aws/s2n-tls/actions/runs/22070958724/job/63775094798The issue is being tracked in the mainline repo: action suddenly no longer available from docker on GitHub actions jidicula/clang-format-action#267
  2. pcap test is failing due to xml parsing failure. Example failure: https://github.com/aws/s2n-tls/actions/runs/22070958716/job/63775094672

How

This PR unblocks the CI by:

  1. Replacing the action with a script that installs clang-format-18 natively then run the same logic as clang-format-action (find files matching the include regex, run clang-format --dry-run --Werror on each one, report failures).
  2. pinning the rtshark version. I suspect this is caused by stricter xml parsing behavior introduced by quick-xml v3.9(dependency of rtshark). I created a public issue to request insight: rtshark 4.2.0: "tag not closed" XML parsing errors when reading from tshark CrabeDeFrance/rtshark#40

Callouts

These are temporary changes to unblock CI. Revert once respective issues are resolved.

Testing

Tests are now passing

Related

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Feb 16, 2026
@jouho jouho marked this pull request as ready for review February 16, 2026 22:51
@jouho jouho requested a review from dougch as a code owner February 16, 2026 22:51
@jouho jouho requested a review from kaukabrizvi February 16, 2026 22:53
Copy link
Copy Markdown
Contributor

@kaukabrizvi kaukabrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure we track these issues so we can revert when it is safe to do so.

@jouho jouho enabled auto-merge February 16, 2026 23:10
@jouho jouho added this pull request to the merge queue Feb 16, 2026
Merged via the queue into aws:main with commit e220839 Feb 16, 2026
53 checks passed
@jouho jouho deleted the fix-clang-format branch February 16, 2026 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants