Merged
Conversation
* add copyright header * clippy --all-targets
maddeleine
approved these changes
Feb 12, 2026
kaukabrizvi
approved these changes
Feb 13, 2026
bindings/rust/standard/s2n-metrics-subscriber/src/emf_emitter.rs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Allow metric records to be converted to EMF.
Why
The metric record is not useful unless we can actually do something with the data. We expect that most customers will be used CloudWatch for analysis/visualization, and EMF is the preferred way to get the metric records ingested in CloudWatch.
How
We use the Metrique Writer interface to handle the actual EMF formatting.
Callouts
The EmfEmitter is intended for future usage through FFI. Accordingly, it has internal buffering to allow a customers to separate that actual record flushing/IO from the aggregation.
Testing
Unit Tests.
I also wrote a simple cloudwatch emitter (not included in this PR) to dump things to CloudWatch and confirm that it made nice lines.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.