fix(benches): reduce flakiness in s2n-tls-bench daily job#5728
Merged
kaukabrizvi merged 2 commits intoaws:mainfrom Feb 17, 2026
Merged
fix(benches): reduce flakiness in s2n-tls-bench daily job#5728kaukabrizvi merged 2 commits intoaws:mainfrom
kaukabrizvi merged 2 commits intoaws:mainfrom
Conversation
maddeleine
approved these changes
Feb 10, 2026
dougch
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
This PR adds the -y flag to the python dependency installation step to avoid flakiness.
Why
The daily s2n-tls-bench job recently failed on the python install step because apt prompted for user confirmation with
[Y/n]and aborted when no input was provided. This is flaky because fresh instances without the packages already cached will trigger apt to download and upgrade packages, which requires confirmation in interactive mode. The build would abort with "Do you want to continue? [Y/n] Abort."How
Adds -y flag which automatically answers "yes" to all prompts, making the apt install command non-interactive and suitable for CI environments. We already exercise this behavior in other codebuild jobs, for example in codebuild/bin/install_ubuntu_dependencies.sh where all apt commands use the -y flag.
Callouts
This job, when run as part of
ScheduledBuildtriggers an alarm when it fails. I will add guidance in the alarm message to resolve the failure and re-run the job as part of the action items, so that we avoid gaps in our benchmarks.Testing
I ran a codebuild job with overrides to run the job from this branch to ensure the changes persist in the CI environment: https://us-west-2.console.aws.amazon.com/codesuite/codebuild/024603541914/projects/s2n-tls-bench/build/s2n-tls-bench%3A4a1ab3d5-2b78-4499-8cac-e66b8155278c/?region=us-west-2
Related
#5693 added the job to codebuild
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.