Skip to content

Necessary changes were made in the s2n module to support AIX OS.#5724

Merged
maddeleine merged 1 commit intoaws:mainfrom
patel-parth7:issue_5723
Feb 26, 2026
Merged

Necessary changes were made in the s2n module to support AIX OS.#5724
maddeleine merged 1 commit intoaws:mainfrom
patel-parth7:issue_5723

Conversation

@patel-parth7
Copy link
Copy Markdown
Contributor

Goal

To support aws-sdk-cpp on AIX and to use the open source library.

Why

Some of the linker flags are not supported on AIX.

How

Callouts

Testing

Testing has been done through aws-sdk-cpp to use the S3 services.

Related

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Some of the linker flags are not supported on AIX.
@patel-parth7
Copy link
Copy Markdown
Contributor Author

Please check #5723 for this PR.

@maddeleine
Copy link
Copy Markdown
Contributor

Hi thanks for the contribution. With this change, do the s2n-tls unit tests actually run and pass on AIX OS?

@patel-parth7
Copy link
Copy Markdown
Contributor Author

patel-parth7 commented Feb 18, 2026

Yes, the s2n-tls unit tests passed on AIX OS. Below is the summary of the test case results.

281/282 Test #281: s2n_x509_validator_test ..........................   Passed    1.77 sec
        Start 282: s2n_x509_validator_time_verification_test
282/282 Test #282: s2n_x509_validator_time_verification_test ........   Passed    2.58 sec

100% tests passed, 0 tests failed out of 282

Label Time Summary:
unit    = 562.89 sec*proc (282 tests)

Total Test time (real) = 563.28 sec

@maddeleine
Copy link
Copy Markdown
Contributor

I think it's fine if we accept this PR, unfortunately we can't run CI on AIX, so we can't guarantee that we won't break this usecase in the future. But since there's no real code changes that need to be made to support AIX, it's fine.
A note though, you should definitely keep running the s2n-tls unit tests on AIX. Minimally, those tests need to pass to say that s2n-tls is working properly in that environment. If one of them fails then it would not be safe to use s2n-tls on that OS.

@maddeleine maddeleine added this pull request to the merge queue Feb 26, 2026
Merged via the queue into aws:main with commit a5a5b87 Feb 26, 2026
67 of 70 checks passed
@patel-parth7
Copy link
Copy Markdown
Contributor Author

Thank you for the review and for considering the PR.
Understood regarding the CI limitation on AIX. We will continue validating the changes on AIX locally to ensure that the build and functionality remain intact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants