nix: Use rustup toolchain over nix packages rustc in devshell#5712
Merged
kaukabrizvi merged 11 commits intoaws:mainfrom Feb 12, 2026
Merged
nix: Use rustup toolchain over nix packages rustc in devshell#5712kaukabrizvi merged 11 commits intoaws:mainfrom
kaukabrizvi merged 11 commits intoaws:mainfrom
Conversation
dougch
approved these changes
Jan 28, 2026
dougch
reviewed
Jan 29, 2026
dougch
approved these changes
Feb 4, 2026
jouho
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Ensure Rust integration tests use the intended rustup-managed toolchain instead of the Nix rustc wrapper.
Why
PR #5711 bumped the MSRV, but CI continued failing with errors indicating rustc 1.86.0 was being used despite a newer toolchain being installed via rustup. In Nix-based devShells, Cargo can still resolve to the Nix rustc wrapper unless the rustup toolchain is explicitly prioritized in the dev shell. This PR removes the previous installation via pkgs.rustc / pkgs.cargo in favor of the rustup-driven toolchain installation to keep Rust versions aligned and up to date.
How
Callouts
Testing
Rebased on #5711 and ran rust_test locally inside of nix and confirmed tests pass
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.