Skip to content

test (integration): add renegotiate rust test#5689

Merged
kaukabrizvi merged 22 commits intoaws:mainfrom
kaukabrizvi:renegotiate_test
Jan 15, 2026
Merged

test (integration): add renegotiate rust test#5689
kaukabrizvi merged 22 commits intoaws:mainfrom
kaukabrizvi:renegotiate_test

Conversation

@kaukabrizvi
Copy link
Copy Markdown
Contributor

@kaukabrizvi kaukabrizvi commented Dec 27, 2025

Goal

Add Rust integration tests that validate OpenSSL-initiated TLS 1.2 renegotiation against an s2n-tls client, including delivery of application data during renegotiation.

Why

We are migrating coverage from IntegV2 to the Rust-based integration test suite. The rust test replaces the IntegV2 test_renegotiate covering the same test cases and more.

How

Introduce Rust integration tests that exercise the ignore, reject, and accept renegotiation paths. A shared helper deterministically drives the renegotiation handshake and optionally validates application data received during renegotiation. The test also adds two test cases that were not present in the IntegV2 test: validating application data delivery during the renegotiation handshake and asserting that an OpenSSL peer reports secure (RFC 5746) renegotiation support when connecting to an s2n-tls client.

Callouts

Renegotiation is not supported in TLS 1.3, so the OpenSSL server is explicitly capped to TLS 1.2 in these tests.

Testing

This is a test, it runs in the PR workflow as part of the IntegRustNix batch.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Dec 27, 2025
@kaukabrizvi kaukabrizvi changed the title [test]: add renegotiate integration test [test]: add renegotiate rust integration test Dec 29, 2025
@kaukabrizvi kaukabrizvi changed the title [test]: add renegotiate rust integration test test (integration): add renegotiate rust test Dec 30, 2025
@kaukabrizvi kaukabrizvi marked this pull request as ready for review January 2, 2026 23:05
@kaukabrizvi kaukabrizvi requested a review from jmayclin January 13, 2026 21:09
@kaukabrizvi kaukabrizvi added this pull request to the merge queue Jan 15, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 15, 2026
@kaukabrizvi kaukabrizvi added this pull request to the merge queue Jan 15, 2026
Merged via the queue into aws:main with commit d8277b5 Jan 15, 2026
53 checks passed
@kaukabrizvi kaukabrizvi deleted the renegotiate_test branch January 15, 2026 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants