Skip to content

Fix: Unpin the rust nightly toolchain version#5682

Merged
boquan-fang merged 5 commits intoaws:mainfrom
VIM4L-M:unpin_nightly_version
Dec 23, 2025
Merged

Fix: Unpin the rust nightly toolchain version#5682
boquan-fang merged 5 commits intoaws:mainfrom
VIM4L-M:unpin_nightly_version

Conversation

@VIM4L-M
Copy link
Copy Markdown
Contributor

@VIM4L-M VIM4L-M commented Dec 19, 2025

Goal

Unpins the rust toolchain version of nightly

Why

If we pin the nightly version, it doesn't seem like we're getting much benefit from testing with it.

How

Unpinning the version of nightly makes it effective to run with the test

Related

resolves #5350

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copilot AI review requested due to automatic review settings December 19, 2025 05:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR unpins the Rust nightly toolchain version to enable continuous testing with the latest nightly release instead of a specific pinned version from December 2024.

Key Changes:

  • Updates the RUST_NIGHTLY_TOOLCHAIN environment variable from nightly-2024-12-01 to nightly

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@VIM4L-M
Copy link
Copy Markdown
Contributor Author

VIM4L-M commented Dec 19, 2025

Hello @goatgoose,
I have raised this PR regarding removing(Unpin) the version of nightly rust toolchain
I hope this resolves the issue

Copy link
Copy Markdown
Contributor

@CarolYeh910 CarolYeh910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@VIM4L-M
Copy link
Copy Markdown
Contributor Author

VIM4L-M commented Dec 23, 2025

Thank you, @CarolYeh910!
I’d love to contribute more in the future.

@boquan-fang boquan-fang added this pull request to the merge queue Dec 23, 2025
Merged via the queue into aws:main with commit 92c6c73 Dec 23, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unpin nightly Rust toolchain version

4 participants