test: confirm errors for no matching parameters#5679
Merged
Conversation
* feature gate tests to TLS 1.3
jmayclin
commented
Dec 18, 2025
|
|
||
| brass-aphid-wire-decryption = "0.0.1" | ||
| brass-aphid-wire-messages = "0.0.1" | ||
| brass-aphid-wire-decryption = "0.0.2" |
Contributor
Author
There was a problem hiding this comment.
I had to release a new version to handle plaintext alerts during the encrypted portion of the handshake.
jmayclin
commented
Dec 18, 2025
bindings/rust/standard/integration/src/handshake_failure_errors.rs
Outdated
Show resolved
Hide resolved
jmayclin
commented
Dec 18, 2025
bindings/rust/standard/integration/src/handshake_failure_errors.rs
Outdated
Show resolved
Hide resolved
CarolYeh910
reviewed
Dec 18, 2025
bindings/rust/standard/integration/src/handshake_failure_errors.rs
Outdated
Show resolved
Hide resolved
kaukabrizvi
reviewed
Dec 18, 2025
bindings/rust/standard/integration/src/handshake_failure_errors.rs
Outdated
Show resolved
Hide resolved
kaukabrizvi
approved these changes
Dec 30, 2025
CarolYeh910
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
This PR adds integration tests to confirm that errors that we return in the event that negotiation failures because there aren't any matching parameters.
Why
This issue was highlighted in #5655. The behavior changed during a recent PR. While unit tests covered this, there is so much noise in our unit tests that the error type change wasn't very obvious.
How
We add rust integration tests configuring an OpenSSL client with a particular parameter set that isn't supported by the s2n-tls server, and then assert on the error that the s2n-tls server returns.
Callouts
I was surprised to find that s2n-tls doesn't fail the handshake when there are no signature schemes in common. It's not immediately clear if this was an accident or intentional. The difficult with changing the behavior is that some clients may (very unfortunately) be relying on it.
Testing
We use brass-aphid-wire to assert on the exact content of the TLS transcript.
Related
#5655
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.