chore: Fix increase in Rust unit test timings#5677
Merged
CarolYeh910 merged 2 commits intoaws:mainfrom Dec 16, 2025
Merged
Conversation
dougch
approved these changes
Dec 16, 2025
CarolYeh910
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
This change will fix a regression we noticed in our Rust bindings unit tests.
Why
I unknowingly caused a regression in a unit test when I added TLS13 ciphersuites to the default policy (#5560). The test was originally erroring without blinding, and my change made it error with blinding. Therefore the unit test timings increased quite a lot.
How
I just changed the server config to use the fixed TLS12 policy, instead of the default policy. I also added some time checks to assert that this test does not trigger blinding, as that was missing from the original test.
Callouts
Another notch for #5557
Testing
Handshake tests should now pass in one second instead of a varying between 10 and 30s.
Mainline test timing:
test result: ok. 8 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 28.54s
PR test timing:
test result: ok. 8 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.13s
Related
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.