(chore): Revert "feat(build): Improve OpenSSL libcrypto discovery (#5572)"#5664
Merged
maddeleine merged 2 commits intoaws:mainfrom Dec 12, 2025
Merged
(chore): Revert "feat(build): Improve OpenSSL libcrypto discovery (#5572)"#5664maddeleine merged 2 commits intoaws:mainfrom
maddeleine merged 2 commits intoaws:mainfrom
Conversation
This reverts commit 13f8249.
CarolYeh910
approved these changes
Dec 11, 2025
dougch
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 13f8249.
Goal
Reverting the recent changes to our cmake libcrypto discovery module.
Why
This change causes linker errors with crt. The problem seems to be that when crt is built with ENABLE_SHARED_LIBS=on, we get errors like "libaws-c-cal.so.1.0.0: undefined reference to `EVP_CIPHER_CTX_reset@OPENSSL_1_1_0". I suspect that the reason why we didn't catch this in our CI is that our crt build doesn't do a shared libs build.
How
Just a direct revert of the PR.
Callouts
I do think we need this change eventually, but if this will cause issues with the CRT then we probably need to just revert this right now. We probably need a more sophisticated way of testing crt in our CI.
Testing
N/A
Related
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.