Fix: print diagnostics to stdout in s2n_resume_test#5660
Merged
CarolYeh910 merged 6 commits intoaws:mainfrom Dec 23, 2025
Merged
Fix: print diagnostics to stdout in s2n_resume_test#5660CarolYeh910 merged 6 commits intoaws:mainfrom
CarolYeh910 merged 6 commits intoaws:mainfrom
Conversation
jmayclin
approved these changes
Dec 16, 2025
Contributor
jmayclin
left a comment
There was a problem hiding this comment.
Thanks for the contribution! It's probably worth pulling in the other stderr usages in test files as well.
CarolYeh910
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Ensure diagnostic messages in
s2n_resume_testare visible when running tests throughCTest.Why
CTestdoes not reliably surface output written tostderr, even when using--output-on-failure.As a result, important diagnostic hints in
s2n_resume_testwere not visible whenever the test failed.How
Replaced all
fprintf(stderr, ...)diagnostic messages ins2n_resume_testwithprintf(...)so the output goes to stdout, whichCTestreliably displays.Callouts
No functional logic changed - only output streams.
This improves developer visibility during failures without altering test behavior.
Testing
Build
Test
Result
Diagnostic messages now appear correctly in test output.
Related
refs: #4112
Output:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.