Merged
Conversation
maddeleine
reviewed
Dec 8, 2025
CarolYeh910
reviewed
Dec 8, 2025
Co-authored-by: maddeleine <59030281+maddeleine@users.noreply.github.com>
CarolYeh910
reviewed
Dec 11, 2025
maddeleine
reviewed
Dec 15, 2025
* use default monotonic clock:w
CarolYeh910
approved these changes
Dec 16, 2025
maddeleine
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Emit a "handshake event", allowing customers to observe multiple pieces of information about the handshake.
Why
Currently customers have to call large numbers of individual "getter" APIs to gather information about the handshake. We expect that with this event structure will eventually be used to aggregate metrics for e.g. emission to CloudWatch.
How
The handshake is emitted to the application through a callback.
Callouts
s2n_event_handshakevss2n_handshake_event? I went with the former because it felt more neatly namespaced.This is adding new code in the hotpath, but it has a minimal impact
Testing
Unit tests, and self-talk tests in the rust bindings.
The tests for this cover a large API surface area, which is tedious to cover in C. Therefore I deliberately have most of the testing in Rust.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.