test: require both MLKem and MLDsa capabilities for pure MLKEM tests#5621
Merged
kaukabrizvi merged 2 commits intoaws:mainfrom Nov 18, 2025
Merged
test: require both MLKem and MLDsa capabilities for pure MLKEM tests#5621kaukabrizvi merged 2 commits intoaws:mainfrom
kaukabrizvi merged 2 commits intoaws:mainfrom
Conversation
CarolYeh910
approved these changes
Nov 17, 2025
dougch
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Require both MLKem and MLDsa capabilities for pure MLKEM Rust integration tests.
Why
Pure MLKEM tests were failing on awslcfips2024, which supports MLKEM but not MLDSA. The test uses MLDSA certificates, so capability gating must reflect that. Once this change is made, the Rust integration test should be stable and can be added as a required test.
How
Update:
for both client and server tests.
Callouts
In the rust integration tests, awslcfips2024 will now skip these tests (expected).
Testing
I ran the rust integration tests on my branch, and the test now succeeds for awslcfips2024.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.