Skip to content

test: require both MLKem and MLDsa capabilities for pure MLKEM tests#5621

Merged
kaukabrizvi merged 2 commits intoaws:mainfrom
kaukabrizvi:puremlkemcapability
Nov 18, 2025
Merged

test: require both MLKem and MLDsa capabilities for pure MLKEM tests#5621
kaukabrizvi merged 2 commits intoaws:mainfrom
kaukabrizvi:puremlkemcapability

Conversation

@kaukabrizvi
Copy link
Copy Markdown
Contributor

@kaukabrizvi kaukabrizvi commented Nov 17, 2025

Goal

Require both MLKem and MLDsa capabilities for pure MLKEM Rust integration tests.

Why

Pure MLKEM tests were failing on awslcfips2024, which supports MLKEM but not MLDSA. The test uses MLDSA certificates, so capability gating must reflect that. Once this change is made, the Rust integration test should be stable and can be added as a required test.

How

Update:

-required_capability_async(&[Capability::MLKem]
+required_capability_async(&[Capability::MLKem, Capability::MLDsa]

for both client and server tests.

Callouts

In the rust integration tests, awslcfips2024 will now skip these tests (expected).

Testing

I ran the rust integration tests on my branch, and the test now succeeds for awslcfips2024.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Nov 17, 2025
@kaukabrizvi kaukabrizvi marked this pull request as ready for review November 17, 2025 22:47
@kaukabrizvi kaukabrizvi requested a review from dougch November 17, 2025 22:48
@kaukabrizvi kaukabrizvi added this pull request to the merge queue Nov 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 17, 2025
@kaukabrizvi kaukabrizvi added this pull request to the merge queue Nov 18, 2025
@kaukabrizvi kaukabrizvi removed this pull request from the merge queue due to a manual request Nov 18, 2025
@kaukabrizvi kaukabrizvi added this pull request to the merge queue Nov 18, 2025
Merged via the queue into aws:main with commit 3165072 Nov 18, 2025
52 checks passed
@kaukabrizvi kaukabrizvi deleted the puremlkemcapability branch November 18, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants