Merged
Conversation
jmayclin
reviewed
Nov 20, 2025
| (CipherSuite::TLS_AES_256_GCM_SHA384, KXGroup::Secp256R1) => "20190802", | ||
| (CipherSuite::TLS_AES_128_GCM_SHA256, KXGroup::X25519) => "20240417", | ||
| (CipherSuite::TLS_AES_256_GCM_SHA384, KXGroup::X25519) => "20190801", | ||
| (CipherSuite::TLS_AES_128_GCM_SHA256, KXGroup::X25519MLKEM768) => "default_tls13", |
Contributor
There was a problem hiding this comment.
- We won't want to use named policies, as they can be updated in the future, so prefer a numbered policy for stability
- I don't think it's correct to have both of these mapping to the same policy. Generally the policy should have the mapped options as the highest preference. When an s2n-tls client is handshaking with an s2n-tls server, it can't negotiated both of these.
Contributor
Author
There was a problem hiding this comment.
Both points make sense. None of the dates-only policies preferred both PQ kex and AES 256, so I used PQ-TLS-1-2-2024-10-09. I don't expect that policy to change through time.
jmayclin
approved these changes
Jan 15, 2026
kaukabrizvi
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Add benchmarks for ML-KEM handshakes.
Why
Performance analysis.
How
By doing the thing.
Callouts
n/a
Testing
Related
n/a
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.