Merged
Conversation
dougch
approved these changes
Nov 10, 2025
Contributor
dougch
left a comment
There was a problem hiding this comment.
Did some checking... Ubuntu18 has 3.10; other older platforms/test don't use cmake.
jmayclin
reviewed
Nov 11, 2025
jmayclin
approved these changes
Nov 11, 2025
jkroonza
reviewed
Nov 12, 2025
| @@ -1,4 +1,4 @@ | |||
| cmake_minimum_required (VERSION 3.9) | |||
| cmake_minimum_required (VERSION 3.10) | |||
There was a problem hiding this comment.
This can be updated to 3.10..3.31 which covers all main versions, I've tested with 3.31 and the build works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
resolves #5607
Why
Gentoo is warning about cmake <3.10 backwards compatibility getting deprecated. We should upgrade to the newer versions of cmake if possible.
How
Change the minimum required cmake version to
3.10Testing
CI should pass
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.