fix: update memory usage test assertions#5592
Merged
Conversation
kaukabrizvi
approved these changes
Oct 30, 2025
* use CI specific numbers for max memory usage
kaukabrizvi
reviewed
Oct 30, 2025
* move Tabled to dev dependency
dougch
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Fix the failing memory test, and add more memory information
Why
The maximum memory usage is not deterministic in CI 😦. So we can't assert on that until we figure it out.
Also, this flakiness is revealing that we don't have a super clear understanding of all the allocations that are happening.
How
So we remove the assertion on max memory, and store all of the heap information.
All of the measurements get printed out in a table, which is copied below.
Callouts
We should also makes the
sensitiveCI job required.Testing
Should pass CI, and also passed locally
Related
#5329 added the memory profiler test.
#5593 is the issue that I opened to investigate the funky max memory behavior.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.