fix: update test broken by Openssl dhe generation change#5580
Merged
fix: update test broken by Openssl dhe generation change#5580
Conversation
boquan-fang
reviewed
Oct 24, 2025
boquan-fang
approved these changes
Oct 24, 2025
maddeleine
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This Openssl commit broke our libcrypto drbg override test: openssl/openssl@d6510d9
My understanding is that basically that commit reduces the size of the generated DHE private key. Changing the private key changes the public key, and that test asserts an exact value of a generated DHE public key in order to prove that the DRBG is properly overridden. The test isn't specifically trying to test the DHE math: the DHE math is just a way to prove we can predict randomness.
Rather than dealing with "what libcrypto/version is this?" I just updated the test to accept either value.
Call-outs:
Before the Openssl change, the generated private key looks like:
After the change, it looks like:
So almost the same, except that first byte?
Testing:
I figured out which commit broke the test via git bisect.
Updated the existing test to allow the new value.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.