feat: add PQ only policy support#5545
Merged
CarolYeh910 merged 19 commits intoaws:mainfrom Oct 24, 2025
Merged
Conversation
goatgoose
reviewed
Oct 8, 2025
tests/policy_snapshot/snapshots/ELBSecurityPolicy-TLS13-1-3-FIPS-PQ-ONLY-2025-09
Show resolved
Hide resolved
carlajarchuleta6-create
approved these changes
Oct 9, 2025
jmayclin
reviewed
Oct 10, 2025
goatgoose
reviewed
Oct 14, 2025
goatgoose
reviewed
Oct 14, 2025
goatgoose
reviewed
Oct 15, 2025
goatgoose
approved these changes
Oct 15, 2025
jmayclin
approved these changes
Oct 16, 2025
Contributor
jmayclin
left a comment
There was a problem hiding this comment.
Do we think that this is funky enough behavior that it'd be worth adding an integration test against openssl?
Contributor
Author
Good callout. I'll add an integration test later in a separate PR. |
goatgoose
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Summary:
Adds support for PQ only policies, which should not include classical ECC curves. This feature only works on libcryptos that support TLS 1.3 and PQ kem groups.
Description of changes:
s2n_generate_default_ecc_key_share()ands2n_process_client_hello()to skip the classical ECC path when a PQ only policy is provided.s2n_config_set_cipher_preferencesors2n_connection_set_cipher_preferences.test_pq_onlyand upload the policy snapshot.s2n_pq_mlkem_policies_test.cand assert on different behaviors/errors depending on libcryptos.Testing:
Existing tests with non PQ-only policies should continue to pass. I also added unit tests specific to PQ-only policies.
Run the test with the latest AWS-LC (PQ supported):
Run the test again with my default libcrypto (PQ unsupported):
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.