ci: pin libloading which requires MSRV 1.71#5520
Merged
Conversation
maddeleine
approved these changes
Sep 22, 2025
boquan-fang
approved these changes
Sep 22, 2025
boquan-fang
reviewed
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
Description of changes:
New version of libloading requires MSRV 1.71, which breaks the CI because out current MSRV is 1.63:
Link to one of the failing builds: https://github.com/aws/s2n-tls/actions/runs/17929332729/job/50983002378?pr=5484
This CR pins its version to previous version 0.8.8.
libloading is a transitive dependency of bindgen. I ran
cargo tree --invert libloadingfrom /s2n-tls/bindings/rust/extended/generate:Call-outs:
I added this pin to our tracking issue: #4395
The performance regression test is failing, but this is expected. The performance regression test switches to mainline and generate the binding (which is broken and what the PR is addressing), so the failure is coming from main branch and not the branch from this PR
Testing:
Tests are now passing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.