Skip to content

ci: pin libloading which requires MSRV 1.71#5520

Merged
lrstewart merged 1 commit intoaws:mainfrom
jouho:pin-libloading
Sep 22, 2025
Merged

ci: pin libloading which requires MSRV 1.71#5520
lrstewart merged 1 commit intoaws:mainfrom
jouho:pin-libloading

Conversation

@jouho
Copy link
Copy Markdown
Contributor

@jouho jouho commented Sep 22, 2025

Release Summary:

Resolved issues:

Description of changes:

New version of libloading requires MSRV 1.71, which breaks the CI because out current MSRV is 1.63:

error: package libloading v0.8.9 cannot be built because it requires rustc 1.71.0 or newer, while the currently active rustc version is 1.63.0

Link to one of the failing builds: https://github.com/aws/s2n-tls/actions/runs/17929332729/job/50983002378?pr=5484
This CR pins its version to previous version 0.8.8.

libloading is a transitive dependency of bindgen. I ran cargo tree --invert libloading from /s2n-tls/bindings/rust/extended/generate:

libloading v0.8.9
├── clang-sys v1.8.1
│   └── bindgen v0.65.1
│       └── generate v0.1.0 (/home/ubuntu/s2n-tls/bindings/rust/extended/generate)
└── generate v0.1.0 (/home/ubuntu/s2n-tls/bindings/rust/extended/generate)

Call-outs:

I added this pin to our tracking issue: #4395

The performance regression test is failing, but this is expected. The performance regression test switches to mainline and generate the binding (which is broken and what the PR is addressing), so the failure is coming from main branch and not the branch from this PR

Testing:

Tests are now passing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Sep 22, 2025
@jouho jouho marked this pull request as ready for review September 22, 2025 22:39
@maddeleine maddeleine self-requested a review September 22, 2025 22:46
@jouho jouho requested a review from boquan-fang September 22, 2025 22:53
@boquan-fang boquan-fang self-requested a review September 22, 2025 22:56
@boquan-fang boquan-fang self-requested a review September 22, 2025 22:58
@lrstewart lrstewart merged commit b5b218c into aws:main Sep 22, 2025
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants