chore(ci): add openssl-1.0.2-fips gcc-4.8 job#5512
Merged
Conversation
7 tasks
goatgoose
approved these changes
Sep 17, 2025
lrstewart
reviewed
Sep 17, 2025
Comment on lines
+230
to
+240
| - buildspec: codebuild/spec/buildspec_ubuntu.yml | ||
| env: | ||
| compute-type: BUILD_GENERAL1_SMALL | ||
| image: 024603541914.dkr.ecr.us-west-2.amazonaws.com/docker:ubuntu18codebuild | ||
| privileged-mode: true | ||
| variables: | ||
| BUILD_S2N: 'true' | ||
| GCC_VERSION: '4.8' | ||
| S2N_LIBCRYPTO: 'openssl-1.0.2-fips' | ||
| TESTS: unit | ||
| identifier: s2nUnitOpenssl102FipsGcc48 |
Contributor
There was a problem hiding this comment.
Wait, was our discussion that we needed a basic unit test to fill that gap? Minimally we'd want an AddressSanitizer, but I think the context of our discussion was integ testing.
Contributor
Author
There was a problem hiding this comment.
I've got all three in PR:
- A 102FIPS/gcc-4.8 unit test here
- A 102Fips/Asan job (using a newer compiler that supports asan) chore(ci): add sanitizer jobs for openssl-1.0.2-fips #5508
- A 102/Fips/gcc-4.8 integration test in chore(ci): Update older integ job to prep for deprecation #5501
lrstewart
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
partial for #5503
Description of changes:
Add a unit test for Openssl-1.0.2-FIPS built with gcc-4.8. As discussed offline, we'd like to continue with testing until such time that LC no longer tests this combo.
Callouts
This replaces an integration test that built aws-lc-FIPS 2022 with gcc-4.8, removed with #5501
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.