test: Adds test for serializing a previously-serialized connection#5495
Merged
maddeleine merged 6 commits intoaws:mainfrom Sep 15, 2025
Merged
test: Adds test for serializing a previously-serialized connection#5495maddeleine merged 6 commits intoaws:mainfrom
maddeleine merged 6 commits intoaws:mainfrom
Conversation
lrstewart
reviewed
Sep 4, 2025
lrstewart
reviewed
Sep 10, 2025
db3dc3d to
cd92632
Compare
lrstewart
approved these changes
Sep 13, 2025
goatgoose
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
N/A
Description of changes:
Just noticed that we don't have test coverage for the case where a connection is serialized, deserialized, and then serialized again. It's a weird usecase but it is completely valid and should work fine.
Call-outs:
N/A
Testing:
Adds new test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.