refactor: signature scheme name adjustment#5472
Merged
Conversation
jmayclin
approved these changes
Aug 20, 2025
goatgoose
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
related to #5471
Description of changes:
Drop "pkcs1" from the legacy RSA signature scheme names. The "pkcs1" is implied by "legacy", and removing it makes the RSA options match the "legacy_<signature_algorithm>_<hash_algorithm>" format.
The 100+ snapshot files are automatically generated and checked by the CI, so shouldn't need review. The only actual changes are in tls/s2n_signature_scheme.c, the last file in the diff.
Testing:
Just a name change. The correctness of the snapshot files is checked by the snapshot test in the CI.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.