ci: start codebuild jobs from github actions#5383
Merged
Conversation
dougch
approved these changes
Jul 9, 2025
|
|
||
| if [ "$#" -lt "1" ]; then | ||
| usage | ||
| # Return instead of exit so we can `source` this script |
Contributor
There was a problem hiding this comment.
It doesn't look like we used this anywhere?
Contributor
Author
There was a problem hiding this comment.
yup, which is why I'm removing it. It used to be part of the linting that ensured the webhooks matched the script (link), but this PR also removes that lint.
maddeleine
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Summary:
Description of changes:
Automatically call start_codebuild.sh to trigger our codebuild jobs. This will only run for members of the aws organization because we have the "Approval for running fork pull request workflows from contributors" set to "Require approval for all external contributors". The status of launched jobs will be communicated back automatically via the Github connector.
This might make adding / removing codebuild jobs a little tricky though: pull_request_target runs with the upstream code, not the new code in the PR that triggers it. That means that if you add a new codebuild job to one of the lists, that codebuild job will not run until AFTER the PR that adds it is merged into main.
Testing:
The new jobs do not run in this PR (see above-- they won't run until this PR is merged). So to test the new workflow, I pushed this code to an aws/s2n-tls branch called "lrstewart2", then I opened two PRs against it from my fork. Those PRs ran the Codebuild jobs.
Positive test: #5390
Negative test: #5389
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.