feat(bindings): expose cert validation callback#5357
Merged
CarolYeh910 merged 10 commits intoaws:mainfrom Sep 30, 2025
Merged
Conversation
goatgoose
reviewed
Jun 16, 2025
goatgoose
reviewed
Sep 24, 2025
bindings/rust/extended/s2n-tls/src/callbacks/cert_validation.rs
Outdated
Show resolved
Hide resolved
lrstewart
reviewed
Sep 25, 2025
bindings/rust/extended/s2n-tls/src/callbacks/cert_validation.rs
Outdated
Show resolved
Hide resolved
goatgoose
reviewed
Sep 25, 2025
bindings/rust/extended/s2n-tls/src/callbacks/cert_validation.rs
Outdated
Show resolved
Hide resolved
bindings/rust/extended/s2n-tls/src/callbacks/cert_validation.rs
Outdated
Show resolved
Hide resolved
bindings/rust/extended/s2n-tls/src/callbacks/cert_validation.rs
Outdated
Show resolved
Hide resolved
goatgoose
reviewed
Sep 26, 2025
bindings/rust/extended/s2n-tls/src/callbacks/cert_validation.rs
Outdated
Show resolved
Hide resolved
bindings/rust/extended/s2n-tls/src/callbacks/cert_validation.rs
Outdated
Show resolved
Hide resolved
jmayclin
reviewed
Sep 26, 2025
bindings/rust/extended/s2n-tls/src/callbacks/cert_validation.rs
Outdated
Show resolved
Hide resolved
goatgoose
reviewed
Sep 29, 2025
bindings/rust/extended/s2n-tls/src/callbacks/cert_validation.rs
Outdated
Show resolved
Hide resolved
bindings/rust/extended/s2n-tls/src/callbacks/cert_validation.rs
Outdated
Show resolved
Hide resolved
bindings/rust/extended/s2n-tls/src/callbacks/cert_validation.rs
Outdated
Show resolved
Hide resolved
bindings/rust/extended/s2n-tls/src/callbacks/cert_validation.rs
Outdated
Show resolved
Hide resolved
goatgoose
approved these changes
Sep 29, 2025
lrstewart
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Summary:
Add a synchronous rust binding API for
s2n_cert_validation_callbackResolved issues:
resolves #5264
Description of changes:
s2n_cert_validation_callbackis an unstable async callback that operates on the structs2n_cert_validation_info. However, due to a lifetime issue (#5469) in our rust bindings, this PR only exposed the synchronous rust API for the cert validation callback.Code changes breakdown:
cert_validation.rsand gated behindfeature = "unstable-crl".s2n_cert_validation_infoin a Rust structCertValidationInfoand implementedaccept()andreject()methods corresponding to the C APIs.CertValidationCallbackSyncand added a config APIset_cert_validation_callback_sync().accept()orreject().Testing:
CertValidationCallbackSyncfor a test structSyncCallbackset_application_context()I ran the unit test locally and confirmed it passed:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.