Flip Nix integration tests to use uv/pytest#5352
Merged
Conversation
Co-authored-by: James Mayclin <maycj@amazon.com>
5 tasks
lrstewart
reviewed
Jun 17, 2025
Contributor
lrstewart
left a comment
There was a problem hiding this comment.
I don't think the PR name is accurate. You're not adding the renegotiate apache to nix, and you're not just adding it to uv, you're switching all the nix tests over to uv.
lrstewart
approved these changes
Jul 10, 2025
jmayclin
approved these changes
Jul 11, 2025
| @@ -0,0 +1,22 @@ | |||
| <Module test_buffered_send.py> | |||
Contributor
There was a problem hiding this comment.
Just to confirm, this level of snapshotting is at the test level, and not the case level, right?
So we'd fail if we stopped running test_early_data, but we won't fail if we just dropped one of the test_early_data cases?
I guess this would be nasty to track across CI configurations 🤔
Contributor
Author
There was a problem hiding this comment.
Correct; the case level was attempted in #5266, but it's significantly more complex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
resolves #5040
Description of changes:
Removes the nix shell function
integand replaces it withuvinteg, also eliminating calling out individual integration tests in a list.To mitigate for missing tests, this PR also adds in a snapshot check using pytest's
--collect-onlyflag, comparing a list of expected tests with what pytest sees and failing if they don't match. Here is a branch, without the renegotiate_apache test in the snapshot list, failing.Call-outs:
This adds a cleanup routine for apache2 configs, so when doing local runs of the integration tests, the apache2 configs get regenerated. This is not needed in CI, as we're throwing away Docker containers after the test runs.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Local, CI.
How can you convince your reviewers that this PR is safe and effective?
Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?
Remember:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.