chore(nix): Flip awslc to upstream flake.#5317
Merged
Conversation
goatgoose
approved these changes
Jul 30, 2025
jmayclin
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
Resolves #5322
Description of changes:
While working through getting the aws-lc flake merged, we used a branch. Now that LC has a flake on main, it's time to start using it.
Call-outs:
This will setup the nix CI job to always use mainline aws-lc.
Reminder that updating the flake.nix file requires a
nix flake updateand checking in the correspondingflake.lockTesting:
How is this change tested (unit tests, fuzz tests, etc.)? locally, and in CI
How can you convince your reviewers that this PR is safe and effective? try it yourself:
nix develop .#awslc; awslc versionIs this a refactor change? no.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.