Closed
Conversation
lrstewart
approved these changes
Mar 13, 2025
Contributor
|
We'll also need this set on the test lib, since that doesn't inherit anymore: Line 484 in 898ba21 |
Contributor
Author
|
@camshaft to be clear, you want that to be PRIVATE as well? |
Contributor
|
It's a library that's used internally so it's probably fine to have it |
Contributor
Author
|
I would rather leave this PR as-is to reduce risk and keep the changes focused. I don't have an easy way to test the proposed change to the testing lib anyway. |
Contributor
|
Closing this PR, as your commits were merged in with #5227 . Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
resolves #5188
Description of changes:
Change fPIC flag to PRIVATE so that it is not propagated to targets that link s2n
Call-outs:
Testing:
Built successfully.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.