Closed
Conversation
jmayclin
commented
Jan 9, 2025
| #include "tests/s2n_test.h" | ||
| #include "utils/s2n_safety.h" | ||
|
|
||
| #define SERVER_CHAIN "/home/ubuntu/workspace/s2n-tls/tests/pems/permutations/rsae_pkcs_2048_sha256/server-chain.pem" |
Contributor
Author
There was a problem hiding this comment.
Eww. Don't do this.
| @@ -0,0 +1,145 @@ | |||
| #include <openssl/err.h> | |||
| ################# sslv2 formatted client hello test ################### | ||
| ############################################################################ | ||
|
|
||
| add_executable(s2n_sslv2_client_hello_handshake tests/integration_c/test_sslv2_handshake.c) |
Contributor
Author
There was a problem hiding this comment.
gate logic behind OpenSSL root and interning
jmayclin
commented
Jan 9, 2025
|
|
||
| int main() | ||
| { | ||
| // Assert that we are pulling in the correct openssl header. |
jmayclin
commented
Jan 9, 2025
| SSL_load_error_strings(); | ||
| EXPECT_SUCCESS(s2n_init()); | ||
|
|
||
| /* s2n-tls client w/ openssl server */ |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| /* s2n-tls client w/ openssl server */ | |
| /* openssl client w/ s2n-tls server */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Part of #4585
Description of changes:
s2n-tls doesn't currently have any integration tests that do a full handshake with an SSLv2 formatted client hello. This PR adds a test.
This is done using an in-process test that handshakes over shared memory. This allows the test to run quickly, and also allows a high degree of observability (assertions can be fine grained). This is also useful because we need access to very specific configuration that would be painful to specify through the command line.
Testing:
New test. We confirm that the ClientHello is actually an SSLv2 client hello in the ClientHello callback.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.