Conversation
dougch
commented
Dec 17, 2024
goatgoose
reviewed
Dec 18, 2024
boquan-fang
reviewed
Dec 18, 2024
Contributor
boquan-fang
left a comment
There was a problem hiding this comment.
Could you put the testing result in the Testing: section in the PR description? I think that part is missing. I think it's helpful to ping test results for a PR involves structure changes.
goatgoose
approved these changes
Dec 19, 2024
boquan-fang
approved these changes
Dec 19, 2024
Contributor
boquan-fang
left a comment
There was a problem hiding this comment.
Testing has been updated.
jmayclin
reviewed
Dec 19, 2024
goatgoose
reviewed
Dec 20, 2024
Co-authored-by: Sam Clark <3758302+goatgoose@users.noreply.github.com>
jmayclin
reviewed
Dec 20, 2024
Co-authored-by: James Mayclin <maycj@amazon.com>
Co-authored-by: James Mayclin <maycj@amazon.com>
jmayclin
approved these changes
Dec 20, 2024
jmayclin
approved these changes
Dec 21, 2024
goatgoose
approved these changes
Dec 21, 2024
Contributor
There was a problem hiding this comment.
For the followup list: I think we'll also want rustfmt and asan running in the standard workspace.
Co-authored-by: Sam Clark <3758302+goatgoose@users.noreply.github.com>
Co-authored-by: Sam Clark <3758302+goatgoose@users.noreply.github.com>
Co-authored-by: Sam Clark <3758302+goatgoose@users.noreply.github.com>
boquan-fang
approved these changes
Dec 23, 2024
This was referenced Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
#4971 and https://github.com/aws/s2n-tls/security/dependabot/1
Description of changes:
Due to hyper dependencies, move it out of our bindings workspace to allow for a newer Rust version and security updates.
Final directory structure, with a different MSRV for extneded, standard and rust-examples.
Call-outs:
This PR is going the refactor-all-the-things approach, many of the files are unchanged, but path depth is growing by one, across the board.
The regression test GHA will fail, because a path change breaks the flip back to the main branch, this will need an over-ride or a limited-time not required change.
Followups
Testing:
This PR is tested by Rust bindings CI.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.