Changed function declarations to match their definitions#3243
Merged
maddeleine merged 2 commits intoaws:mainfrom Mar 23, 2022
Merged
Changed function declarations to match their definitions#3243maddeleine merged 2 commits intoaws:mainfrom
maddeleine merged 2 commits intoaws:mainfrom
Conversation
lrstewart
approved these changes
Mar 22, 2022
alexw91
approved these changes
Mar 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved issues:
resolves #2989
Description of changes:
gcc-11 added a new error called array-parameter, which warns about redeclarations of functions involving arguments of array or pointer types of inconsistent kinds (See release notes for more details). I fixed the places where these inconsistencies occur, in most cases, I just changed the function declaration to match the definition.
Call-outs:
I did not add gcc11 to our build, that might be a future project, although it should be pretty easy.
Testing:
s2n can be compiled with gcc11 with -Werror turned on. Basically I just did 'make CC=gcc-11'
Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.