Use page-aligned allocation only if required#317
Merged
colmmacc merged 2 commits intoaws:masterfrom Sep 27, 2016
Merged
Conversation
Previously, we were nonconditionally doing page-aligned allocations. This is only required if the user wishes to mlock all s2n data. For performance, let's disable alignment if it isn't required. closes aws#110
colmmacc
reviewed
Sep 26, 2016
| b->size = size; | ||
| return 0; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Would we better doing something like:
if (!use_mlock) {
b->data = realloc(b->data ...)
madvice(DONT_DUMP) ...
return 0;
here? There's a lot of logic in this function to duplicate what realloc may do more efficiently.
Contributor
Author
There was a problem hiding this comment.
Agreed. Makes that branch terminal as well
colmmacc
reviewed
Sep 27, 2016
| b->data = data; | ||
| b->size = size; | ||
| b->allocated = size; | ||
| return 0; |
Contributor
There was a problem hiding this comment.
We need to do the DONTDUMP here if we want to preserve that behavior.
Contributor
Author
There was a problem hiding this comment.
Per http://man7.org/linux/man-pages/man2/madvise.2.html , madvise needs a page-aligned pointer as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we were nonconditionally doing page-aligned allocations.
This is only required if the user wishes to mlock all s2n data. For
performance, let's disable alignment if it isn't required.
closes #110