feat: use new read/load assembly functions everywhere#3600
Merged
mergify[bot] merged 51 commits intomainfrom Jun 28, 2022
Merged
feat: use new read/load assembly functions everywhere#3600mergify[bot] merged 51 commits intomainfrom
mergify[bot] merged 51 commits intomainfrom
Conversation
…ath always loads SPEC_FILE_NAME first
…onroy/jsiiutils-extension
…onroy/jsiiutils-extension
RomainMuller
suggested changes
Jun 28, 2022
packages/@jsii/kernel/src/kernel.ts
Outdated
Comment on lines
121
to
124
| } catch { | ||
| throw new Error( | ||
| `Package tarball ${req.tarball} must have a file named ${spec.SPEC_FILE_NAME} at the root`, | ||
| ); |
Contributor
There was a problem hiding this comment.
Blind catch is a bit of an anti-pattern. The throw underneath makes wild assumptions about what failed. It should at least log the actual thing it caught here...
kaizencc
commented
Jun 28, 2022
Comment on lines
+121
to
+122
| } catch (e: any) { | ||
| throw new Error(`Error for package tarball ${req.tarball}: ${e.message}`); |
Contributor
Author
There was a problem hiding this comment.
Good catch, @RomainMuller, is this better?
RomainMuller
approved these changes
Jun 28, 2022
RomainMuller
approved these changes
Jun 28, 2022
Contributor
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Contributor
|
Merging (with squash)... |
1 similar comment
Contributor
|
Merging (with squash)... |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR utilizes the functions added in #3570 everywhere in the jsii monorepo. The benefit of this is two-fold -- it refactors all places where we load/read assemblies and points them to the source of truth (introduced in #3570). This also means the logic for compressing assemblies will be available for all packages in the jsii monorepo if/when we flip that switch.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.