The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged.
[Conventional Commits]: https://www.conventionalcommits.org

Relates to #4982

Looking at the other dependencys, I wonder if the closing paranthesis is really what is intended. Probably also with the other dependencies, a closing bracket makes sense?

@michaelmejaeger thanks for the PR. I'm not a maven expert, but I think the intention was to say that this works with 2.18.x and below. Hence the use of ) to exclude. Now it seems like that this will include pre-release versions which is just wild to me. 🤯

Is there a better way to indicate the above intention? We can probably also go to the latest 2.20.1.

@mrgrain Okay, if this was the intention, then you could use the range [2.11.3,2.18.999999]. This seems to align with the Maven versioning specification).

I am not sure, what is the best solution here, since I do not fully understand the intention here. I understand that a minimum version is required. But is there a maximum version lower than 3.0.0? Isn't it true, that according to semantic versioning, all higher versions should fit in?

P. S.: If you want to play around with version numbers and version ranges then you can use the following JBang script:

//usr/bin/env jbang "$0" "$@" ; exit $?
//DEPS org.apache.maven:maven-artifact:3.9.6

import org.apache.maven.artifact.versioning.ComparableVersion;
import org.apache.maven.artifact.versioning.VersionRange;
import org.apache.maven.artifact.versioning.ArtifactVersion;

public class VersionInRange {
    public static void main(String[] args) throws Exception {
        if (args.length != 2) {
            System.err.println("Usage: jbang VersionInRange.java <version> <versionRange>");
            System.exit(1);
        }

        String versionStr = args[0];
        String rangeStr = args[1];

        ComparableVersion version = new ComparableVersion(versionStr);
        VersionRange range = VersionRange.createFromVersionSpec(rangeStr);

        ArtifactVersion artifactVersion = new org.apache.maven.artifact.versioning.DefaultArtifactVersion(versionStr);

        boolean inRange = range.containsVersion(artifactVersion);

        System.out.println("Version " + versionStr + " is " + (inRange ? "IN" : "NOT IN") + " range " + rangeStr);
    }
}

@mrgrain Okay, if this was the intention, then you could use the range [2.11.3,2.18.999999].

I was about to suggest that as well, fun to see that my hacky though process aligns with how it should be done.

I think we could probably also go for [2.11.3,2.99999.0] and assume that Maven will hold itself to semver.

But is there a maximum version lower than 3.0.0?

No, I think that would be the goal. What I meant is that at the time 2.18.x would have been the highest available version.

If [2.11.3,2.99999.0] is the canonical way to declare "anything but v3" (on the upper boundary) than we should do that.

I fixed the PR accordingly to the upper version number 2.99999.0.

Nice, thank you! There's a build issue I need to look at and fix. I'll get back to this.

@Mergifyio requeue

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

Merging (with squash)...