Skip to content

Added EFA helm chart#1040

Merged
jdn5126 merged 1 commit intoaws:masterfrom
zachdorame:master
Dec 15, 2023
Merged

Added EFA helm chart#1040
jdn5126 merged 1 commit intoaws:masterfrom
zachdorame:master

Conversation

@zachdorame
Copy link
Copy Markdown
Contributor

@zachdorame zachdorame commented Dec 14, 2023 •
edited by jdn5126
Loading

Issue

N/A

Description of changes

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

ran make verify

Results (only for EFA chart):

Validating chart aws-efa-k8s-device-plugin/ w/ helm v3
WARN - Set to ignore missing schemas
PASS - aws-efa-k8s-device-plugin/templates/daemonset.yaml contains a valid DaemonSet (release-name-aws-efa-k8s-device-plugin)
Validating chart aws-efa-k8s-device-plugin/ w/ helm v2
WARN - Set to ignore missing schemas
PASS - aws-efa-k8s-device-plugin/templates/daemonset.yaml contains a valid DaemonSet (release-name-aws-efa-k8s-device-plugin)

Linting chart aws-efa-k8s-device-plugin/ w/ helm v3
==> Linting /Volumes/workplace/eks-charts/stable/aws-efa-k8s-device-plugin/

1 chart(s) linted, 0 chart(s) failed
Linting chart aws-efa-k8s-device-plugin/ w/ helm v2
==> Linting /Volumes/workplace/eks-charts/stable/aws-efa-k8s-device-plugin/
Lint OK

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zachdorame zachdorame requested a review from bwagner5 as a code owner December 14, 2023 21:55
jdn5126
jdn5126 reviewed Dec 14, 2023
View reviewed changes
jdn5126
jdn5126 reviewed Dec 14, 2023
View reviewed changes
@zachdorame zachdorame requested a review from jdn5126 December 14, 2023 22:32
jdn5126
jdn5126 reviewed Dec 15, 2023
View reviewed changes
@zachdorame zachdorame requested a review from jdn5126 December 15, 2023 01:05
@jdn5126 jdn5126 merged commit b626b46 into aws:master Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwagner5 bwagner5 Awaiting requested review from bwagner5

1 more reviewer

@jdn5126 jdn5126 jdn5126 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zachdorame @jdn5126