Allow skipping whitespace cleanup#23
Closed
ecederstrand wants to merge 2 commits intoaws:masterfrom
ecederstrand:allow-skipping-whitespace-cleanup
Closed
Allow skipping whitespace cleanup#23ecederstrand wants to merge 2 commits intoaws:masterfrom ecederstrand:allow-skipping-whitespace-cleanup
ecederstrand wants to merge 2 commits intoaws:masterfrom
ecederstrand:allow-skipping-whitespace-cleanup
Conversation
added 2 commits
October 25, 2018 20:01
Default to the existing behavior. The flag allows skipping whitespace filtering of the input stream.
Member
|
Could you isolate the relevant commit in this PR? Looks like it currently includes the changes in #22 as well. I don't think that making the whitespace removal optional is the right approach. I would rather we find a more efficient way of performing it if this is an issue. Have you seen a performance issue with the whitespace removal? I'm wondering if just always passing through |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #21
Allow skipping whitespace cleanup. Defaults to the existing behavior. The flag allows skipping whitespace filtering of the input stream for performance reasons.
This is a suggested fix to the first item in the referenced issue.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.