Conversation
…rDown The test_interactive_pipeline_user_only_created_once integration test was flaky because tearDown called delete_stack without waiting for completion. On reruns or subsequent test executions, the stack could still exist (DELETE_IN_PROGRESS), causing CreateChangeSet to fail with 'Stack already exists and cannot be created again with the changeSet InitialCreation'. Add a waiter after delete_stack calls in tearDown that polls every 10s up to a 180s timeout, ensuring stacks are fully deleted before the next test begins. Timeouts are logged as warnings without failing teardown.
fead39e to
b13fdb4
Compare
seshubaws
approved these changes
Mar 11, 2026
licjun
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
test_interactive_pipeline_user_only_created_onceintegration test was flaky in CI (run #268).tearDowncallsdelete_stackbut doesn't wait for the deletion to complete. On reruns (via--reruns) or back-to-back test executions, the stack can still be inDELETE_IN_PROGRESS, causingCreateChangeSetto fail:Fix
Add a CloudFormation waiter in
tearDownthat polls every 10s (up to 180s) for each stack deletion to complete before moving on. Timeouts log a warning without failing teardown.Testing