fix(unzip): replace UserException with ValueError exception in _extract()#8599
Merged
fix(unzip): replace UserException with ValueError exception in _extract()#8599
_extract()#8599Conversation
_extract()
0c98d41 to
3c594f6
Compare
valerena
reviewed
Jan 27, 2026
valerena
approved these changes
Jan 27, 2026
bnusunny
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
ModuleNotFoundError: No module named 'samcli'.gitignoreWhy is this change necessary?
During Terraform builds, SAM CLI copies
zip.pyfromsamcli/local/lambdafn/to an isolated temporary directory (.aws-sam-iacs/iacs_metadata/) where it's executed as part of the build process. The original code importedUserExceptionfromsamcli.commands.exceptions, but thesamclipackage is not available in this isolated directory, causing the import to fail withModuleNotFoundError.How does it address the issue?
This change replaces the custom
UserExceptionwith Python's built-inValueErrorexception in the_extractfunction withinsamcli/local/lambdafn/zip.py. This eliminates the dependency on SAM CLI's internal module structure, makingzip.pyself-contained and able to run successfully when copied to the isolated metadata directory. The error handling behavior remains functionally equivalent.samcli/hook_packages/terraform/hooks/prepare/makefile_generator.py(lines 96-97)Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.