fix: add mount-with write for java25 tests#8579
Merged
Conversation
Contributor
Author
|
Integ test run: https://github.com/aws/aws-sam-cli/actions/runs/21048079873 |
reedham-aws
previously approved these changes
Jan 15, 2026
valerena
reviewed
Jan 15, 2026
|
|
||
| overrides = self.get_override(runtime, code_path, architecture, "aws.example.Hello::myHandler") | ||
| cmdlist = self.get_command_list(use_container=use_container, parameter_overrides=overrides) | ||
| mount_with = MountMode.WRITE if use_container and str(runtime).lower() == "java25" else None |
Contributor
There was a problem hiding this comment.
If I remember correctly, in practice we need mount-with-write only for the Gradle tests. Is it possible to add this only for those?
Contributor
Author
There was a problem hiding this comment.
yup that's what I'm adding now since I noticed the maven tests failing that weren't failing before. new integ test run https://github.com/aws/aws-sam-cli/actions/runs/21051712748
valerena
approved these changes
Jan 16, 2026
reedham-aws
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
Gradle 9 (which Java25 uses) requires the addition of the --mount-with WRITE flag.
How does it address the issue?
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.