Conversation
Member
Author
valerena
approved these changes
Jan 9, 2026
seshubaws
reviewed
Jan 12, 2026
|
|
||
| self.assertTrue(lmi_subnet_id, "LMI_SUBNET_ID environment variable must be set") | ||
| self.assertTrue(lmi_security_group_id, "LMI_SECURITY_GROUP_ID environment variable must be set") | ||
| self.assertTrue(lmi_operator_role_arn, "LMI_OPERATOR_ROLE_ARN environment variable must be set") |
Contributor
There was a problem hiding this comment.
why are we deleting this?
Contributor
There was a problem hiding this comment.
This was added before SAM able to create operator role automatically. We can now remove this role since we will test automatic role creation.
vicheey
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
The integration tests were generating numerous
ResourceWarningmessages about unclosed files and sockets:sys:1: ResourceWarning: unclosed <socket.socket ...>sys:1: ResourceWarning: unclosed file <_io.TextIOWrapper ...>subprocess X is still runningwarningsDeprecation warning on python3.9
LMI tests are not correctly skipped
How does it address the issue?
Close process/handles on teardown
update to python3.11 for testing
LMI skipped at class level
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.