fix: build durable emulator image and copy binary to it #8484
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
We found a bug in the latest release of SAM CLI in the emulator creation process. It seems to be only affecting the Mac installer; we were able to test executions on Linux and Windows successfully.
The issue manifests like this:
The underlying issue is that while the binary itself exists in the artifacts for the release, they don't get copied into the container image properly.
How does it address the issue?
We need to create a new image from the base image (Ubuntu), and copy the emulator binaries into it, and then set the executable permissions on the emulator binary. This is the correct approach to the container image creation, and follows the pattern that the lambda container uses when generating the runtime images to run the function code.
I validated it by running the pyinstaller script manually and symlinked the build output artifacts to run an execution:
What side effects does this change have?
None.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.