Conversation
…deployment oom kill issue CloudFront with S3 OAC returns a 403 instead of a 404 when an object is missing from an S3 bucket, and so the redirect for single-page apps was broken. Updated to handle both 403 and 404 to be safe. Additionally bumped the default memory size for the bucket deployment lambda which was being killed due to exceeding the memory limit for just the default website. Fixes #915, Fixes #909
|
View your CI Pipeline Execution ↗ for commit c13dfd9.
☁️ Nx Cloud last updated this comment at |
agdimech
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CloudFront with S3 OAC returns a 403 instead of a 404 when an object is missing from an S3 bucket, and so the redirect for single-page apps was broken. Updated to handle both 403 and 404 to be safe.
Additionally bumped the default memory size for the bucket deployment lambda which was being killed due to exceeding the memory limit for just the default website.
Fixes #915
Fixes #909