Skip to content

feat(type-safe-api): add support for additional request parameters in s3 integration#926

Merged
cogwirrel merged 3 commits intoaws:mainlinefrom
v41e:feat/s3-additional-request-parameters
Jun 17, 2025
Merged

feat(type-safe-api): add support for additional request parameters in s3 integration#926
cogwirrel merged 3 commits intoaws:mainlinefrom
v41e:feat/s3-additional-request-parameters

Conversation

@v41e
Copy link
Copy Markdown
Contributor

@v41e v41e commented Jun 16, 2025

This PR adds logic to support additional request parameters and mapping to path, improving integration with S3.

Changes:

  • added handling for extra request parameters in the construct props
  • implemented mapping logic to correctly resolve and map paths for S3 integration

@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Jun 16, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit e2789fe.

Command Status Duration Result
nx run-many --target=build --output-style=strea... ✅ Succeeded 13m 21s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-17 06:37:30 UTC

cogwirrel
cogwirrel reviewed Jun 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@cogwirrel cogwirrel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! 😄

Please could you add a simple unit test for these changes too?

@v41e
Copy link
Copy Markdown
Contributor Author

v41e commented Jun 17, 2025

Done, I hope AWS will move from JSONpath to JSONata in API Gateway (like they did in Step Function) in order to allow simple transformation.

For example to allow to set a default value if a query param is missing.

@cogwirrel
Copy link
Copy Markdown
Member

cogwirrel commented Jun 17, 2025

Done, I hope AWS will move from JSONpath to JSONata in API Gateway (like they did in Step Function) in order to allow simple transformation.

For example to allow to set a default value if a query param is missing.

Thank you! :)

I wonder if you can achieve that with APIGateway's VTL, eg something like this? https://docs.aws.amazon.com/apigateway/latest/developerguide/apigateway-override-request-response-parameters.html#apigateway-override-request-response-examples-2

@cogwirrel cogwirrel merged commit 3558363 into aws:mainline Jun 17, 2025
3 checks passed
@v41e
Copy link
Copy Markdown
Contributor Author

v41e commented Jun 17, 2025

i didn't know request template has a context.requestOverride

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cogwirrel cogwirrel cogwirrel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@v41e @cogwirrel