feat: export sys variables from aws-lc-rs crate#335
Merged
Conversation
8462b5f to
f994bb1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 60 60
Lines 7868 7868
=======================================
Hits 7540 7540
Misses 328 328 ☔ View full report in Codecov by Sentry. |
justsmth
reviewed
Jan 31, 2024
justsmth
previously approved these changes
Feb 1, 2024
skmcgrail
reviewed
Feb 6, 2024
skmcgrail
reviewed
Feb 6, 2024
justsmth
approved these changes
Feb 9, 2024
skmcgrail
approved these changes
Feb 9, 2024
225737d to
4cf7dd5
Compare
This was referenced Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change exports the underlying
*-syscrate in theaws-lc-rscrate. This is needed for a couple of reasons:aws-lc-sys = "0.12". In s2n-quic, we depend onaws-lc-rs = ">=1.5". When a newaws-lc-rsversion is published, then we get conflicting resolutions and end up with 2 copies ofaws-lc-sys. Symbol prefixing is currently not working well enough to prevent conflicts.aws-lc-sysdirectly, they'll have to duplicate thefips/non-fipsfeature switching logic that's already present inaws-lc-rs. This logic is a bit complicated so it'd be nice to have it implemented in a single location.With this change, s2n-tls will instead depend on
aws-lc-rs = "1". This will avoid issues of preventing it using the latest aws-lc-sys crates on newer releases. It'll also make it easier to pick upfipsbuilds, since we rely on the logic inaws-lc-rs.Call-outs:
I did some minor refactoring to the build scripts to try and make it a bit clearer.
Testing:
I've expanded the
sys-testingcrate to include the new functionality.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.