Merged
Conversation
09c63b4 to
e697aa2
Compare
8a80f78 to
e697aa2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3094 +/- ##
==========================================
- Coverage 78.16% 78.15% -0.02%
==========================================
Files 689 689
Lines 121628 121627 -1
Branches 16982 16982
==========================================
- Hits 95074 95059 -15
- Misses 25670 25684 +14
Partials 884 884 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nebeid
approved these changes
Mar 12, 2026
WillChilds-Klein
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
The
RSADecryptionPrimitiveCRTfunction in the ACVP modulewrapper leaks 8 BIGNUMs on every call.RSA_new_private_key_large_etakesconst BIGNUM*parameters and copies them internally, but the originals were never freed.RSASignaturePrimitiveandRSADecryptionPrimitivehad the same issue on their error paths (beforeRSA_set0_keytakes ownership).Under ASAN, LeakSanitizer reports these leaks to stderr when the modulewrapper exits. Since
check_expected.gocaptures combined stdout+stderr, the leak output gets mixed into the ACVP test result, causing a mismatch against the expected output.All three functions now use
bssl::UniquePtr<BIGNUM>for automatic cleanup.Testing:
Existing ACVP tests in the FIPS ASAN CI job should now pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.