Fix PKCS7 verify content memleak#3036
Merged
WillChilds-Klein merged 3 commits intoaws:mainfrom Feb 25, 2026
Merged
Conversation
8042d6c to
be16161
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3036 +/- ##
==========================================
+ Coverage 78.31% 78.35% +0.03%
==========================================
Files 689 689
Lines 120995 121035 +40
Branches 16971 16991 +20
==========================================
+ Hits 94758 94831 +73
+ Misses 25341 25307 -34
- Partials 896 897 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eb7781b to
f676569
Compare
justsmth
approved these changes
Feb 25, 2026
samuel40791765
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
Previously we failed to free the whole BIO chain in PKCS7_verify, instead just popping the head. To remediate, we need to iterate through the chain until we hit
indata(owned by the caller), freeing as we go.Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.