Fix error return values for no-op UI_xxx stub functions#3025
Merged
Fix error return values for no-op UI_xxx stub functions#3025
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
AWS-LC provides no-op stub implementations of several OpenSSL
UI_xxxfunctions to allow compilation of projects that reference them for non-essential operations. These stubs always fail at runtime since the UI API is unsupported.Previously,
UI_add_input_string,UI_add_verify_string,UI_add_info_string, andUI_processall returned0. In OpenSSL's UI API,-1indicates failure:UI_add_input_string,UI_add_verify_string, andUI_add_info_stringall delegate togeneral_allocate_string(), which returns a positive index on success and-1on error.UI_processreturns0on success and-1on error.In practice, callers should already be checking the
NULLreturn fromUI_newand never reaching these functions. This change simply corrects the return values to be consistent with the OpenSSL API contract, and updates the corresponding header documentation to match.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.